v1.x #1623 follow up -add missing types to package.json#1773
v1.x #1623 follow up -add missing types to package.json#1773felixweinberger merged 2 commits intov1.xfrom
Conversation
|
commit: |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — straightforward addition of missing types fields to package.json exports, following the established pattern.
Extended reasoning...
Overview
This PR adds missing types fields to 5 export entries in package.json: ./validation, ./validation/ajv, ./validation/cfworker, ./experimental, and ./experimental/tasks. This is a follow-up to PR #1623 which added typings exports but missed these entries.
Security risks
None. This is a package.json metadata change only — no code, no dependencies, no auth or crypto changes.
Level of scrutiny
Minimal scrutiny needed. The change is purely mechanical: each added types field follows the exact same ./dist/esm/<path>.d.ts convention already established by the existing ., ./client, and ./server entries. The types field is correctly placed first in each conditional export object, which is the recommended order for TypeScript resolution.
Other factors
No outstanding reviewer comments. No bugs found. The changeset bot flagged no changeset, which is appropriate for a metadata-only fix. The pattern is consistent and correct across all entries.
There was a problem hiding this comment.
LGTM - straightforward addition of missing types fields to package.json exports, following the established pattern.
Extended reasoning...
Overview
This PR adds missing types fields to 5 subpath exports in package.json: ./validation, ./validation/ajv, ./validation/cfworker, ./experimental, and ./experimental/tasks. It follows up on PR #1623 which added typings exports but missed these entries.
Security risks
None. This is a package.json metadata change only — no code, no logic, no auth, no data handling.
Level of scrutiny
Minimal scrutiny needed. This is a mechanical, pattern-following change to a single config file. The existing exports for ., ./client, and ./server already have types fields in the exact same format. The new entries follow the same convention (types listed first, pointing to ./dist/esm/...d.ts).
Other factors
No bugs found. No outstanding reviewer comments. No CODEOWNERS concerns for package.json. The change is self-contained and unambiguous. The types field placement (first in each export entry) follows TypeScript's recommended convention for conditional exports.
2 participants
Follow up to #1623
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context